dcapwell commented on code in PR #40:
URL: https://github.com/apache/cassandra-accord/pull/40#discussion_r1157808290
##########
accord-core/src/main/java/accord/utils/async/AsyncResult.java:
##########
@@ -79,7 +79,11 @@ default void setSuccess(V value)
default void setFailure(Throwable throwable)
{
if (!tryFailure(throwable))
- throw new IllegalStateException("Result has already been set
on " + this);
+ {
+ IllegalStateException e = new IllegalStateException("Result
has already been set on " + this);
Review Comment:
`ReadData.readComplete` some times throws causing this to happen. Rather
than dropping the throwable that we are rejecting, add it to the throwable we
are throwing; that way logs can show what caused this to happen.
This doesn't happen once
https://issues.apache.org/jira/browse/CASSANDRA-18364 is applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
