5 commented on code in PR #2251:
URL: https://github.com/apache/cassandra/pull/2251#discussion_r1158534482


##########
src/java/org/apache/cassandra/db/SSTableImporter.java:
##########
@@ -182,19 +185,35 @@ synchronized List<String> importNewSSTables(Options 
options)
 
         try (Refs<SSTableReader> refs = Refs.ref(newSSTables))
         {
+            abortIfDraining();
             cfs.getTracker().addSSTables(newSSTables);
             for (SSTableReader reader : newSSTables)
             {
                 if (options.invalidateCaches && cfs.isRowCacheEnabled())
                     invalidateCachesForSSTable(reader);
             }
-
+        }
+        catch (Throwable t)
+        {
+            logger.error("[{}] FaiFailed adding sstables", importID, t);
+            throw new RuntimeException("Failed adding sstables", t);

Review Comment:
   Fixed here and in six other places within this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to