dcapwell commented on code in PR #2259:
URL: https://github.com/apache/cassandra/pull/2259#discussion_r1158854823
##########
test/simulator/test/org/apache/cassandra/simulator/paxos/HistoryValidatorTest.java:
##########
@@ -356,79 +383,146 @@ private static Event writeOnly(int pk)
return new Event(EnumSet.of(Event.Type.WRITE), pk, null);
}
- private void fromLog(String log)
+ private interface Operation
Review Comment:
honestly I prefer interfaces over abstract class, and having an abstract
class just too hold `pk` is not something I care too much for.
so this points down to style, and I prefer this style =)
> Is there any reason not to make the variable private?
redundant so not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
