jacek-lewandowski commented on PR #2046: URL: https://github.com/apache/cassandra/pull/2046#issuecomment-1498555729
> > One more general idea is to have all those get/set methods in an interface as defaults and inherit them in CassandraRelevantProperties and the env counterpart > > Doesn't this go against our code style. We don't add get/set methods if there's not a reason to do so, and we don't add interfaces unless there's a reason to do so. I'm not suggesting adding any new methods, just moving the existing methods to the interface because they can not go to a superclass (enums). The only difference between `CassandraRelevantProperties` and `CassandraRelevantEnvs` is the method they use to get the raw string. Sorry for the confusion - no set methods to be moved, just get. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
