iamaleksey commented on code in PR #2256:
URL: https://github.com/apache/cassandra/pull/2256#discussion_r1176355229
##########
src/java/org/apache/cassandra/service/accord/async/AsyncAppender.java:
##########
@@ -69,12 +72,23 @@ public boolean append()
return state == State.FINISHED;
}
- @Override
- public void run()
+ private void onFinished(@Nullable Throwable error)
{
commandStore.checkInStoreThread();
Invariants.checkState(state == State.WAITING, "Expected WAITING state
but was %s", state);
state = State.FINISHED;
- callback.accept(null, null);
+ callback.accept(error, null);
Review Comment:
Indeed. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
