belliottsmith commented on code in PR #38: URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1176923491
########## accord-core/src/main/java/accord/messages/SafeCallback.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package accord.messages; + +import java.util.Objects; +import java.util.concurrent.Executor; + +import accord.api.Agent; +import accord.coordinate.Timeout; +import accord.local.Node; + +public class SafeCallback<T extends Reply> +{ + private final Executor executor; + private final Agent agent; + private final Callback<T> callback; + + public SafeCallback(Executor executor, Agent agent, Callback<T> callback) + { + this.executor = Objects.requireNonNull(executor, "executor"); + this.agent = Objects.requireNonNull(agent, "agent"); + this.callback = Objects.requireNonNull(callback, "callback"); + } + + public void success(Node.Id src, T reply) + { + safeCall(src, () -> callback.onSuccess(src, reply)); Review Comment: I don't love the double wrapping of capturing continuations here. Perhaps something like: ``` public void success(Node.Id src, T reply) { safeCall(src, reply, Callback::onSuccess); } public void slowResponse(Node.Id src) { safeCall(src, null, (id, ignore) -> callback.onSlowResponse(id)); } public void failure(Node.Id to, Throwable t) { safeCall(to, t, Callback::onFailure); } interface SafeCall<T, P> { void accept(Callback<T> callback, Node.Id id, P param) throws Throwable; } private <P> void safeCall(Node.Id src, P param, SafeCall<T, P> call) { executor.execute(() -> { try { call.accept(callback, src, param); } catch (Throwable t) { try { callback.onCallbackFailure(src, t); } catch (Throwable t2) { t.addSuppressed(t2); agent.onUncaughtException(t); } } }); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
