dcapwell commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1177091742
##########
accord-core/src/main/java/accord/local/CommandStores.java:
##########
@@ -65,19 +67,23 @@ CommandStores<?> create(NodeTimeService time,
private final DataStore store;
private final ProgressLog.Factory progressLogFactory;
private final CommandStore.Factory shardFactory;
+ private final RandomSource random;
- Supplier(NodeTimeService time, Agent agent, DataStore store,
ProgressLog.Factory progressLogFactory, CommandStore.Factory shardFactory)
+ Supplier(NodeTimeService time, Agent agent, DataStore store,
RandomSource random, ProgressLog.Factory progressLogFactory,
CommandStore.Factory shardFactory)
{
this.time = time;
this.agent = agent;
this.store = store;
+ this.random = random;
this.progressLogFactory = progressLogFactory;
this.shardFactory = shardFactory;
}
CommandStore create(int id, RangesForEpochHolder rangesForEpoch)
{
- return shardFactory.create(id, time, agent, store,
progressLogFactory, rangesForEpoch);
+ CommandStore store = shardFactory.create(id, time, agent,
this.store, progressLogFactory, rangesForEpoch);
+ store.execute(() -> CommandStore.register(store));
Review Comment:
The default is `execute(() -> CommandStore.register(this));` which adds the
current to the shared `ThreadLocal`; this default is used by
`AccordCommandStore`, `SingleThread`, and `Debug` (as it extends
`SingleThread`).
There are 2 non-threaded based `CommandStore`s that mark this method as a
no-op: that is `Synchronized` and `DelayedCommandStore`
> The SingleThread implementation seems to not override register, even
though it seemingly has no reason to use the Unsafe implementation, since it is
able to just consult its Thread register, as this is of course much simpler and
cheaper.
What do you mean by `Unsafe`? The current logic calls
`CommandStore.register(this)` and that method *hides* `Unsafe` type...
both `SingleThread` and `AccordCommandStore` schedule a `Runnable` in their
`Executor` which will call `CommandStore.register(this)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
