maedhroz commented on code in PR #2267: URL: https://github.com/apache/cassandra/pull/2267#discussion_r1178646875
########## src/java/org/apache/cassandra/io/sstable/format/bti/BtiFormatPartitionWriter.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.io.sstable.format.bti; + +import java.io.IOException; + +import org.apache.cassandra.config.DatabaseDescriptor; +import org.apache.cassandra.db.ClusteringComparator; +import org.apache.cassandra.db.SerializationHeader; +import org.apache.cassandra.db.rows.Unfiltered; +import org.apache.cassandra.io.sstable.format.SortedTablePartitionWriter; +import org.apache.cassandra.io.sstable.format.Version; +import org.apache.cassandra.io.sstable.format.bti.RowIndexReader.IndexInfo; +import org.apache.cassandra.io.util.SequentialWriter; + +/** + * Partition writer used by {@link BtiTableWriter}. + * <p> + * Writes all passed data to the given SequentialWriter and if necessary builds a RowIndex by constructing an entry + * for each row within a partition that follows {@link org.apache.cassandra.config.Config#column_index_size} of written + * data. + */ +class BtiFormatPartitionWriter extends SortedTablePartitionWriter +{ + private final RowIndexWriter rowTrie; + private final int indexSize; + private int rowIndexCount; + + BtiFormatPartitionWriter(SerializationHeader header, + ClusteringComparator comparator, + SequentialWriter dataWriter, + SequentialWriter rowIndexWriter, + Version version) + { + this(header, comparator, dataWriter, rowIndexWriter, version, DatabaseDescriptor.getColumnIndexSize()); + } + + + BtiFormatPartitionWriter(SerializationHeader header, + ClusteringComparator comparator, + SequentialWriter dataWriter, + SequentialWriter rowIndexWriter, + Version version, + int indexSize) + { + super(header, dataWriter, version); + this.indexSize = indexSize; + this.rowTrie = new RowIndexWriter(comparator, rowIndexWriter); + } + + @Override + public void reset() + { + super.reset(); + rowTrie.reset(); + rowIndexCount = 0; + } + + @Override + public void addUnfiltered(Unfiltered unfiltered) throws IOException + { + super.addUnfiltered(unfiltered); + + // if we hit the column index size that we have to index after, go ahead and index it. + if (currentPosition() - startPosition >= indexSize) + addIndexBlock(); + } + + @Override + public void close() + { + rowTrie.close(); + } + + public long finish() throws IOException + { + long endPosition = super.finish(); + + // the last row may have fallen on an index boundary already. if not, index it explicitly. + if (rowIndexCount > 0 && firstClustering != null) + addIndexBlock(); + + if (rowIndexCount > 1) + { + return rowTrie.complete(endPosition); + } + else + { + // Otherwise we don't complete the trie. Even if we did write something (which shouldn't be the case as the + // first entry has an empty key and root isn't filled), that's not a problem. + return -1; + } + } + + protected void addIndexBlock() throws IOException + { + IndexInfo cIndexInfo = new IndexInfo(startPosition, + startOpenMarker); + rowTrie.add(firstClustering, lastClustering, cIndexInfo); + firstClustering = null; + ++rowIndexCount; + } + + public int getRowIndexCount() Review Comment: nit: If `rowIndexCount` becomes, `blockCount`, rename... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
