michaelsembwever commented on code in PR #2294:
URL: https://github.com/apache/cassandra/pull/2294#discussion_r1179647210


##########
doc/modules/cassandra/pages/new/4.1-new.adoc:
##########


Review Comment:
   continuing on 
https://github.com/apache/cassandra/pull/2198#discussion_r1175812840
   
   Note keeping these as separate files means we will have duplicate pages 
under the different versions, and runs the risk of those pages not being kept 
in sync.
   
   e.g. if i go update `4.1-new.adoc` in the cassandra-4.1 branch I would not 
know or notice that those changes would have to be applied to a different file 
when forward-merging that into trunk.
   
   also note that the `4.0-new.adoc` is not here.
   
   otherwise it's nice to have all the versions listed in one place by using 
the includes… just worried about maintenance of this by others…



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to