iamaleksey commented on code in PR #2256:
URL: https://github.com/apache/cassandra/pull/2256#discussion_r1183593226
##########
src/java/org/apache/cassandra/journal/Flusher.java:
##########
@@ -270,15 +270,15 @@ private void
waitForFlushGroup(ActiveSegment<K>.Allocation alloc)
pending.decrementAndGet();
}
- private void asyncFlushGroup(ActiveSegment<K>.Allocation alloc, Executor
executor, Runnable onDurable)
+ private void asyncFlushGroup(ActiveSegment<K>.Allocation alloc, Executor
executor, AsyncWriteCallback callback)
{
pending.incrementAndGet();
callbackExecutor.execute(() ->
{
alloc.awaitFlush(journal.metrics.waitingOnFlush);
pending.decrementAndGet();
written.incrementAndGet();
- executor.execute(onDurable);
+ executor.execute(callback);
Review Comment:
Resolving as above ^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]