dcapwell commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1186553294
##########
src/java/org/apache/cassandra/utils/vint/VIntCoding.java:
##########
@@ -318,6 +373,61 @@ else if (size == 9)
}
}
+ @Inline
+ public static <V> int writeVInt(long value, V output, int offset,
ValueAccessor<V> accessor)
+ {
+ return writeUnsignedVInt(encodeZigZag64(value), output, offset,
accessor);
+ }
+
+ @Inline
+ public static <V> int writeVInt32(int value, V output, int offset,
ValueAccessor<V> accessor)
+ {
+ return writeVInt(value, output, offset, accessor);
+ }
+
+ @Inline
+ public static <V> int writeUnsignedVInt32(int value, V output, int offset,
ValueAccessor<V> accessor)
+ {
+ return writeUnsignedVInt(value, output, offset, accessor);
+ }
+
+ @Inline
+ public static <V> int writeUnsignedVInt(long value, V output, int offset,
ValueAccessor<V> accessor)
Review Comment:
TODO should add test to make sure this matches `bb`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]