JeetKunDoug commented on code in PR #2318:
URL: https://github.com/apache/cassandra/pull/2318#discussion_r1191303114
##########
src/java/org/apache/cassandra/utils/MBeanWrapper.java:
##########
@@ -170,6 +186,125 @@ public void unregisterMBean(ObjectName mbeanName,
OnException onException)
}
}
+ static class InstanceMBeanWrapper implements MBeanWrapper
+ {
+ private final MBeanServer mbs;
+ public final UUID id = UUID.randomUUID();
+
+ public InstanceMBeanWrapper(String hostname)
+ {
+ mbs = MBeanServerFactory.createMBeanServer(hostname + "-" + id);
+ }
+
+ public void registerMBean(Object obj, ObjectName mbeanName,
OnException onException)
Review Comment:
So added the `@Override` annotations and looking at the result, it just adds
a ton of noise to the file (and the diff) - will discuss in person and we can
figure out which way we want to go here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
