maedhroz commented on code in PR #2329: URL: https://github.com/apache/cassandra/pull/2329#discussion_r1192825490
########## test/unit/org/apache/cassandra/cql3/CQLTesterTest.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3; + +import org.junit.Test; + +import org.apache.cassandra.utils.Pair; +import org.assertj.core.api.Assertions; + +public class CQLTesterTest extends CQLTester +{ + @Test + public void testGetCreateIndexName() + { + schemaChange("CREATE KEYSPACE k WITH replication = {'class': 'SimpleStrategy', 'replication_factor': '1'}"); + schemaChange("CREATE KEYSPACE k2 WITH replication = {'class': 'SimpleStrategy', 'replication_factor': '1'}"); + String table = createTable("CREATE TABLE %s (k int PRIMARY KEY, c int)"); + + // standard index with explicit name + testGetCreateIndexName("k", "idx", "CREATE INDEX idx ON k.t (c)"); + testGetCreateIndexName(KEYSPACE, "idx", "CREATE INDEX idx ON t (c)"); + testGetCreateIndexName(KEYSPACE, "idx", "CREATE INDEX idx ON %s (c)"); + + // custom index with explicit name + testGetCreateIndexName("k", "idx", "CREATE CUSTOM INDEX idx ON k.t (c) USING 'class'"); + testGetCreateIndexName(KEYSPACE, "idx", "CREATE CUSTOM INDEX idx ON t (c) USING 'class'"); + testGetCreateIndexName(KEYSPACE, "idx", "CREATE CUSTOM INDEX idx ON %s (c) USING 'class'"); + + // with a unqouted case-sensitive index name Review Comment: ```suggestion // with an unqouted case-sensitive index name ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
