smiklosovic commented on code in PR #2331: URL: https://github.com/apache/cassandra/pull/2331#discussion_r1193023955
########## test/unit/org/apache/cassandra/db/virtual/ClientsTableKeyspaceColTest.java: ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.virtual; + +import java.io.IOException; +import java.net.InetAddress; +import java.util.List; + +import com.google.common.collect.ImmutableList; +import org.junit.AfterClass; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; + +import com.datastax.driver.core.Cluster; +import com.datastax.driver.core.Row; +import com.datastax.driver.core.Session; +import org.apache.cassandra.ServerTestUtils; +import org.apache.cassandra.config.DatabaseDescriptor; +import org.apache.cassandra.service.EmbeddedCassandraService; + +public class ClientsTableKeyspaceColTest +{ + + private static Cluster cluster; + private static EmbeddedCassandraService cassandra; + private static final String KS_NAME = "vts"; + + @BeforeClass + public static void setupClass() throws IOException + { + cassandra = ServerTestUtils.startEmbeddedCassandraService(); + + cluster = Cluster.builder().addContactPoint("127.0.0.1") + .withPort(DatabaseDescriptor.getNativeTransportPort()) + .build(); + + ClientsTable table = new ClientsTable(KS_NAME); + VirtualKeyspaceRegistry.instance.register(new VirtualKeyspace(KS_NAME, ImmutableList.of(table))); + } + + @AfterClass + public static void tearDown() + { + if (cluster != null) + cluster.close(); + if (cassandra != null) + cassandra.stop(); + } + + @Test + public void testWithoutConnectingToKeyspace() + { + try (Session session = cluster.connect()) + { + List<Row> rows = session.execute("SELECT * from " + KS_NAME + ".clients").all(); + Assert.assertTrue("At least one client should be returned.", rows.size() > 0); + for (Row r : rows) + { + // No keyspace is specifed while connecting. 'keyspace' column should be null. + Assert.assertNull(r.getString("keyspace_name")); + } + } + } + + @Test + public void testChangingKeyspace() + { + String keyspace1 = "system_distributed"; + String keyspace2 = "system_auth"; + try (Session session = cluster.connect(keyspace1)) + { + + InetAddress poolConnection = null; + int port = -1; + List<Row> rows = session.execute("SELECT * from " + KS_NAME + ".clients").all(); + for (Row r : rows) + { + // Keyspace is used for pool connection only (control connection is not using keyspace). + // Using keyspace != null as a hint to identify a pool connection as we can't identify + // control connection based on information in this table. + String keyspace = r.getString("keyspace_name"); + if (keyspace1.equals(keyspace)) + { + poolConnection = r.getInet("address"); + port = r.getInt("port"); Review Comment: Is not it true that you can `break` from this loop once we enter this `if` and `poolConnection` and `port` are set? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
