mike-tr-adamson commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1193619873
##########
src/antlr/Parser.g:
##########
@@ -1525,8 +1525,8 @@ collectionLiteral returns [Term.Raw value]
listLiteral returns [Term.Raw value]
@init {List<Term.Raw> l = new ArrayList<Term.Raw>();}
- @after {$value = new Lists.Literal(l);}
- : '[' ( t1=term { l.add(t1); } ( ',' tn=term { l.add(tn); } )* )? ']' {
$value = new Lists.Literal(l); }
+ @after {$value = new ArrayLiteral(l);}
+ : '[' ( t1=term { l.add(t1); } ( ',' tn=term { l.add(tn); } )* )? ']' {
$value = new ArrayLiteral(l); }
Review Comment:
I noticed this previously but isn't this a duplication? We either need
`@after {$value = new ArrayLiteral(l);}` or we need `{ $value = new
ArrayLiteral(l); }` but I don't think we need both of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
