frankgh commented on code in PR #45: URL: https://github.com/apache/cassandra-sidecar/pull/45#discussion_r1194293237
########## client/src/test/java/org/apache/cassandra/sidecar/client/selection/RandomInstanceSelectionPolicyTest.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.client.selection; + +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import org.apache.cassandra.sidecar.client.SidecarInstance; +import org.apache.cassandra.sidecar.client.SidecarInstancesProvider; +import org.apache.cassandra.sidecar.client.SimpleSidecarInstancesProvider; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatExceptionOfType; +import static org.mockito.Mockito.mock; + +/** + * Unit tests for the {@link RandomInstanceSelectionPolicy} + */ +class RandomInstanceSelectionPolicyTest +{ + List<SidecarInstance> mockInstanceList; + + @BeforeEach + void setup() + { + mockInstanceList = Arrays.asList(mock(SidecarInstance.class), mock(SidecarInstance.class), + mock(SidecarInstance.class), mock(SidecarInstance.class) + ); + } + + @Test + public void testIterator() + { + SidecarInstancesProvider provider = new SimpleSidecarInstancesProvider(mockInstanceList); + InstanceSelectionPolicy instanceSelectionPolicy = new RandomInstanceSelectionPolicy(provider); + Iterator<SidecarInstance> iterator = instanceSelectionPolicy.iterator(); + + assertThat(iterator.hasNext()).isTrue(); + assertThat(iterator.hasNext()).isTrue().as("Expected to be true"); Review Comment: testing idempotency of hasNext. I will add a comment to make it clear ########## client/src/test/java/org/apache/cassandra/sidecar/client/selection/OrderedInstanceSelectionPolicyTest.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.client.selection; + +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import org.apache.cassandra.sidecar.client.SidecarInstance; +import org.apache.cassandra.sidecar.client.SidecarInstancesProvider; +import org.apache.cassandra.sidecar.client.SimpleSidecarInstancesProvider; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatExceptionOfType; +import static org.mockito.Mockito.mock; + +/** + * Unit tests for the {@link OrderedInstanceSelectionPolicy} + */ +class OrderedInstanceSelectionPolicyTest +{ + List<SidecarInstance> mockInstanceList; + SidecarInstance mockInstance1; + SidecarInstance mockInstance2; + SidecarInstance mockInstance3; + SidecarInstance mockInstance4; + + @BeforeEach + void setup() + { + mockInstance1 = mock(SidecarInstance.class); + mockInstance2 = mock(SidecarInstance.class); + mockInstance3 = mock(SidecarInstance.class); + mockInstance4 = mock(SidecarInstance.class); + mockInstanceList = Arrays.asList(mockInstance1, mockInstance2, mockInstance3, mockInstance4); + } + + @Test + public void testIterator() + { + + SidecarInstancesProvider provider = new SimpleSidecarInstancesProvider(mockInstanceList); + InstanceSelectionPolicy instanceSelectionPolicy = new OrderedInstanceSelectionPolicy(provider); + Iterator<SidecarInstance> iterator = instanceSelectionPolicy.iterator(); + + assertThat(iterator.hasNext()).isTrue(); + assertThat(iterator.hasNext()).isTrue().as("Expected to be true"); Review Comment: testing idempotency of hasNext. I will add a comment to make it clear -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
