jakubzytka commented on code in PR #2336:
URL: https://github.com/apache/cassandra/pull/2336#discussion_r1195422589
##########
test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java:
##########
@@ -176,83 +179,177 @@ public TestCase nodes(int nodeCount)
return this;
}
- /** performs all supported upgrade paths that exist in between from
and end on CURRENT (inclusive)
- * {@code upgradesToCurrentFrom(3.0); // produces: 3.0 -> CURRENT,
3.11 -> CURRENT, …}
- **/
- public TestCase upgradesToCurrentFrom(Semver from)
Review Comment:
The term `path` is not ambiguous when used in the context of graph
traversal, just like in this case.
I agree that using the term "edge" would be better than e.g. "a path with
length 1" which I used, but I wanted to retain a connection to the previous
formulation so that a reader that is already familiar with the old API and
javadocs has the proper intuition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
