dcapwell commented on code in PR #46:
URL: https://github.com/apache/cassandra-accord/pull/46#discussion_r1198340488
##########
accord-core/src/main/java/accord/topology/Topology.java:
##########
@@ -236,7 +236,9 @@ private Topology forSubset(int[] newSubset, Collection<Id>
nodes)
return new Topology(epoch, shards, ranges, nodeLookup, rangeSubset,
newSubset);
}
- private <P1> int[] subsetFor(Unseekables<?, ?> select,
IndexedPredicate<P1> predicate, P1 param)
+ private enum OnUnknown { REJECT, IGNORE }
Review Comment:
this was actually a hack to make progress...
What I saw was that the local epoch=1, but we saw epoch=2, we try to see if
there is overlap and fail as epoch=1 doesn't have the new table range that is
defined in epoch=2
I changed C* code to defer exec of messages and `PreLoadContext` until the
epoch they depend on is ready... which may remove the need for this hack...
This likely hasn't been found in burn due to working with a single range, so
only would impact new ranges being added and used right away (which happens in
C* tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
