jonmeredith commented on code in PR #2326:
URL: https://github.com/apache/cassandra/pull/2326#discussion_r1199486163
##########
relocate-dependencies.pom:
##########
@@ -67,7 +67,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
+ <version>3.4.1</version>
Review Comment:
is this bump required to make things work?
##########
test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java:
##########
@@ -35,7 +35,7 @@
import org.apache.cassandra.distributed.api.Feature;
import org.apache.cassandra.distributed.api.IInstanceConfig;
import org.apache.cassandra.distributed.shared.NetworkTopology;
-import org.apache.cassandra.distributed.shared.Shared;
+import org.apache.cassandra.utils.Shared;
import org.apache.cassandra.distributed.upgrade.UpgradeTestBase;
Review Comment:
fix import ordering
##########
test/distributed/org/apache/cassandra/distributed/impl/Instance.java:
##########
@@ -815,6 +1012,9 @@ public Future<Void> shutdown(boolean graceful)
// ScheduledExecutors shuts down after MessagingService, as
MessagingService may issue tasks to it.
error = parallelRun(error, executor, () ->
ScheduledExecutors.shutdownAndWait(1L, MINUTES));
+
+ error = parallelRun(error, executor,
+ this::stopJmx);
Review Comment:
single line like 3.11?
##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -70,11 +70,11 @@
import org.apache.cassandra.distributed.api.NodeToolResult;
import org.apache.cassandra.distributed.api.TokenSupplier;
import org.apache.cassandra.distributed.shared.InstanceClassLoader;
-import org.apache.cassandra.distributed.shared.Isolated;
+import org.apache.cassandra.utils.Isolated;
import org.apache.cassandra.distributed.shared.MessageFilters;
import org.apache.cassandra.distributed.shared.Metrics;
import org.apache.cassandra.distributed.shared.NetworkTopology;
-import org.apache.cassandra.distributed.shared.Shared;
+import org.apache.cassandra.utils.Shared;
Review Comment:
should re-order position in import list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
