Maxwell-Guo commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1194526987
##########
test/unit/org/apache/cassandra/cql3/CQLTester.java:
##########
@@ -1564,13 +1569,24 @@ public static void assertRows(UntypedResultSet result,
Object[]... rows)
{
Object actualValueDecoded = actualValue == null ? null :
column.type.getSerializer().deserialize(actualValue);
if (!Objects.equal(expected != null ? expected[j] : null,
actualValueDecoded))
+ {
+ //TODO confirm this isn't a bug...
Review Comment:
[//TODO](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamRequest.java#L111)
[//
TODO](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/batchlog/BatchlogManager.java#L477)
it seems both are all exists, so I think we can just keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
