jbellis commented on PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#issuecomment-1563324033
Here's what I get on my branch w/ the old syntax:
```
org.apache.cassandra.exceptions.InvalidRequestException: Cannot infer type
of argument ? in call to function system.cosine_similarity(float vector, float
vector): use type casts to disambiguate
at
org.apache.cassandra.cql3.functions.FunctionFactory.getOrCreateFunction(FunctionFactory.java:101)
at
org.apache.cassandra.cql3.functions.FunctionResolver.lambda$collectCandidates$1(FunctionResolver.java:144)
at
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
at
java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1621)
at
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
at
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at
java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
at
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at
java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
at
org.apache.cassandra.cql3.functions.FunctionResolver.collectCandidates(FunctionResolver.java:146)
at
org.apache.cassandra.cql3.functions.FunctionResolver.get(FunctionResolver.java:96)
at
org.apache.cassandra.cql3.functions.FunctionResolver.get(FunctionResolver.java:72)
at
org.apache.cassandra.cql3.selection.Selectable$WithFunction$Raw.prepare(Selectable.java:415)
at
org.apache.cassandra.cql3.selection.RawSelector.prepare(RawSelector.java:53)
at
org.apache.cassandra.cql3.selection.RawSelector.lambda$toSelectables$0(RawSelector.java:48)
at
com.google.common.collect.Lists$TransformingRandomAccessList.get(Lists.java:603)
at
org.apache.cassandra.cql3.selection.SelectorFactories.<init>(SelectorFactories.java:99)
at
org.apache.cassandra.cql3.selection.SelectorFactories.createFactoriesAndCollectColumnDefinitions(SelectorFactories.java:85)
at
org.apache.cassandra.cql3.selection.Selection.fromSelectors(Selection.java:188)
at
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepareSelection(SelectStatement.java:1212)
at
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1142)
at
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1124)
at
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1096)
at
org.apache.cassandra.cql3.QueryProcessor.parseAndPrepare(QueryProcessor.java:435)
at
org.apache.cassandra.cql3.QueryProcessor.prepareInternal(QueryProcessor.java:413)
at
org.apache.cassandra.cql3.QueryProcessor.executeInternal(QueryProcessor.java:446)
at
org.apache.cassandra.cql3.CQLTester.executeFormattedQuery(CQLTester.java:1364)
at org.apache.cassandra.index.sai.SAITester.execute(SAITester.java:600)
at
org.apache.cassandra.index.sai.cql.VectorTypeTest.similarityFunctionTest(VectorTypeTest.java:224)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
```
test running is
```
@Test
public void similarityFunctionTest() throws Throwable
{
createTable("CREATE TABLE %s (pk int, str_val text, val float
vector[3], PRIMARY KEY(pk))");
execute("INSERT INTO %s (pk, str_val, val) VALUES (0, 'A', ?)",
Lists.newArrayList(1.0, 2.0 ,3.0));
execute("INSERT INTO %s (pk, str_val, val) VALUES (1, 'B', ?)",
Lists.newArrayList(2.0 ,3.0, 4.0));
UntypedResultSet result = execute("SELECT pk, val,
cosine_similarity(val, ?) FROM %s", Lists.newArrayList(2.5, 3.5, 4.5));
assertThat(result).hasSize(2);
System.out.println(makeRowStrings(result));
}
```
full code in the branch at
https://github.com/jbellis/cassandra/tree/vector-functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
