adelapena commented on code in PR #2367: URL: https://github.com/apache/cassandra/pull/2367#discussion_r1206691424
########## .circleci/generate.sh: ########## @@ -176,7 +180,7 @@ elif (!($has_env_vars)); then fi # add new or modified tests to the sets of tests to be repeated -if (!($all)); then +if (! ($all) && ! ($skip_changed_test_detection)); then Review Comment: This can be simplified by inverting the meaning of the var: https://github.com/adelapena/cassandra/commit/33ffb5fa30477317dabde9e64eea4f7a3cfe99a1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
