smiklosovic commented on code in PR #2373:
URL: https://github.com/apache/cassandra/pull/2373#discussion_r1207172854


##########
tools/stress/src/org/apache/cassandra/stress/StressAction.java:
##########
@@ -155,15 +159,22 @@ private boolean runMulti(boolean auto, UniformRateLimiter 
rateLimiter)
             results.add(result);
 
             if (prevThreadCount > 0)
-                System.out.println(String.format("Improvement over %d 
threadCount: %.0f%%",
-                        prevThreadCount, 100 * averageImprovement(results, 
1)));
+            {
+                double avgImprovement = 100 * 
target.averageImprovement(results, 1);

Review Comment:
   for latency, the "improvement" is hard to describe as the test is stressing 
a cluster in such a way that even throughput is better, the latency will suffer 
so it will be progressively worse. The default returned from 
`averageImprovement` is `0` if not overloaded in the implementations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to