michaelsembwever commented on PR #2336: URL: https://github.com/apache/cassandra/pull/2336#issuecomment-1567515180
> This is a valid point, but is not a problem today and out-of-scope. AFAIK no one is passing patch-number explicit versions to these methods. I agree that an assertion that we don't (yet) support patch-specific bounds would be appropriate. Instead of adding an assertion, I've added the apidoc. It is ok if patch versions are passed to the the `edgeTouchesTarget(..)` method, it is intentionally only compares majors and minors. The potential bug you describe won't happen, because it is not this method that applies the bounds. That happens with the `vertices.subSet(..)` call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
