Maxwell-Guo commented on code in PR #2369:
URL: https://github.com/apache/cassandra/pull/2369#discussion_r1209708986
##########
test/distributed/org/apache/cassandra/distributed/test/guardrails/GuardrailPartitionSizeTest.java:
##########
@@ -75,12 +75,11 @@ protected Cluster getCluster()
@Test
public void testPartitionSize()
{
+ // test yaml-loaded config
testPartitionSize(WARN_THRESHOLD, FAIL_THRESHOLD);
- }
+ schemaChange("DROP TABLE %s");
Review Comment:
one more question : why merge the two test case into one ?"test yaml-loaded
config" and "test dynamic config"
as
https://github.com/apache/cassandra/commit/b0aa44b27da97b37345ee6fafbee16d66f3b384f
described
there are two cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
