bereng commented on code in PR #2368:
URL: https://github.com/apache/cassandra/pull/2368#discussion_r1209785269
##########
src/java/org/apache/cassandra/io/util/TrackedDataInputPlus.java:
##########
@@ -49,53 +66,61 @@ public void reset(long count)
public boolean readBoolean() throws IOException
{
+ checkCanRead(1);
Review Comment:
Not following. Why would you need to refactor anything? You guys think `1`
is more readable than `TypeSizes.BOOL_SIZE` and on top of that you're
hardcoding a value?
`checkCanRead(TypeSizes.BOOL_SIZE)` reads good in my eyes :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
