adelapena commented on PR #1891: URL: https://github.com/apache/cassandra/pull/1891#issuecomment-1573945306
> J8 [here](https://app.circleci.com/pipelines/github/bereng/cassandra/970/workflows/2e949ede-cae5-4ab8-a118-43ec6d722b0d). All good as failures are C18065, c18499 and a timeout that has passed many times before in my tests The upgrade test `MixedModeAvailabilityV3XAllOneTest` is broken on trunk, some ten runs are enough to reproduce the timeout: https://app.circleci.com/pipelines/github/adelapena/cassandra/2927/workflows/fcd1cd60-826b-484a-8e81-d3ba640f7de9/jobs/47659/tests. I'll open a ticket for the new flaky. The rest of the results look good to me. However, there is a missed detail which is that the new `storage_compatibility_mode` should reject a `sstable` yaml config using bti/tries if we are in `CASSANDRA_4` compatibility mode. For example, in `DatabseDescriptor.getAndValidateWriteFormat`. Ideally, it should be part of this ticket, but I guess we can do it in a separate follow-up ticket so we can get this merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
