adelapena commented on code in PR #2310: URL: https://github.com/apache/cassandra/pull/2310#discussion_r1226541307
########## test/unit/org/apache/cassandra/cql3/validation/operations/CQLVectorTest.java: ########## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3.validation.operations; + +import java.nio.ByteBuffer; +import java.util.List; + +import org.junit.Assert; +import org.junit.Test; + +import org.apache.cassandra.cql3.CQLTester; +import org.apache.cassandra.cql3.functions.NativeFunctions; +import org.apache.cassandra.cql3.functions.NativeScalarFunction; +import org.apache.cassandra.db.marshal.Int32Type; +import org.apache.cassandra.db.marshal.VectorType; +import org.apache.cassandra.transport.ProtocolVersion; + +public class CQLVectorTest extends CQLTester.InMemory +{ + @Test + public void select() + { + createTable(KEYSPACE, "CREATE TABLE %s (pk vector<int, 2> primary key)"); + + execute("INSERT INTO %s (pk) VALUES ([1, 2])"); + + Vector<Integer> vector = vector(1, 2); + Object[] row = row(vector); + + assertRows(execute("SELECT * FROM %s WHERE pk = [1, 2]"), row); + assertRows(execute("SELECT * FROM %s WHERE pk = ?", vector), row); + assertRows(execute("SELECT * FROM %s WHERE pk = [1, 1 + 1]"), row); + assertRows(execute("SELECT * FROM %s WHERE pk = [1, ?]", 2), row); + assertRows(execute("SELECT * FROM %s WHERE pk = [1, (int) ?]", 2), row); + assertRows(execute("SELECT * FROM %s WHERE pk = [1, 1 + (int) ?]", 1), row); + + assertRows(execute("SELECT * FROM %s WHERE pk IN ([1, 2])"), row); + assertRows(execute("SELECT * FROM %s WHERE pk IN ([1, 2], [1, 2])"), row); + assertRows(execute("SELECT * FROM %s WHERE pk IN (?)", vector), row); + assertRows(execute("SELECT * FROM %s WHERE pk IN ([1, 1 + 1])"), row); + assertRows(execute("SELECT * FROM %s WHERE pk IN ([1, ?])", 2), row); + assertRows(execute("SELECT * FROM %s WHERE pk IN ([1, (int) ?])", 2), row); + assertRows(execute("SELECT * FROM %s WHERE pk IN ([1, 1 + (int) ?])", 1), row); + + assertRows(execute("SELECT * FROM %s WHERE pk > [0, 0] AND pk < [1, 3] ALLOW FILTERING"), row); + assertRows(execute("SELECT * FROM %s WHERE token(pk) = token([1, 2])"), row); + } + + @Test + public void selectNonPk() + { + createTable(KEYSPACE, "CREATE TABLE %s (pk int primary key, value vector<int, 2>)"); + + execute("INSERT INTO %s (pk, value) VALUES (0, [1, 2])"); + assertRows(execute("SELECT * FROM %s WHERE value=[1, 2] ALLOW FILTERING"), row(0, list(1, 2))); + } + + @Test + public void insert() + { + Runnable test = () -> { + assertRows(execute("SELECT * FROM %s"), row(list(1, 2))); + execute("TRUNCATE %s"); + assertRows(execute("SELECT * FROM %s")); + }; + + createTable(KEYSPACE, "CREATE TABLE %s (pk vector<int, 2> primary key)"); + + execute("INSERT INTO %s (pk) VALUES ([1, 2])"); + test.run(); + + execute("INSERT INTO %s (pk) VALUES (?)", vector(1, 2)); + test.run(); + + execute("INSERT INTO %s (pk) VALUES ([1, 1 + 1])"); + test.run(); + + execute("INSERT INTO %s (pk) VALUES ([1, ?])", 2); + test.run(); + + execute("INSERT INTO %s (pk) VALUES ([1, (int) ?])", 2); + test.run(); + + execute("INSERT INTO %s (pk) VALUES ([1, 1 + (int) ?])", 1); + test.run(); + } + + @Test + public void insertNonPK() + { + Runnable test = () -> { + assertRows(execute("SELECT * FROM %s"), row(0, list(1, 2))); + execute("TRUNCATE %s"); + assertRows(execute("SELECT * FROM %s")); + }; + + createTable(KEYSPACE, "CREATE TABLE %s (pk int primary key, value vector<int, 2>)"); + + execute("INSERT INTO %s (pk, value) VALUES (0, [1, 2])"); + test.run(); + + execute("INSERT INTO %s (pk, value) VALUES (0, ?)", vector(1, 2)); + test.run(); + + execute("INSERT INTO %s (pk, value) VALUES (0, [1, 1 + 1])"); + test.run(); + + execute("INSERT INTO %s (pk, value) VALUES (0, [1, ?])", 2); + test.run(); + + execute("INSERT INTO %s (pk, value) VALUES (0, [1, (int) ?])", 2); + test.run(); + + execute("INSERT INTO %s (pk, value) VALUES (0, [1, 1 + (int) ?])", 1); + test.run(); + } + + @Test + public void update() + { + Runnable test = () -> { + assertRows(execute("SELECT * FROM %s"), row(0, list(1, 2))); + execute("TRUNCATE %s"); + assertRows(execute("SELECT * FROM %s")); + }; + + createTable(KEYSPACE, "CREATE TABLE %s (pk int primary key, value vector<int, 2>)"); + + execute("UPDATE %s set VALUE = [1, 2] WHERE pk = 0"); + test.run(); + + execute("UPDATE %s set VALUE = ? WHERE pk = 0", vector(1, 2)); + test.run(); + + execute("UPDATE %s set VALUE = [1, 1 + 1] WHERE pk = 0"); + test.run(); + + execute("UPDATE %s set VALUE = [1, ?] WHERE pk = 0", 2); + test.run(); + + execute("UPDATE %s set VALUE = [1, (int) ?] WHERE pk = 0", 2); + test.run(); + + execute("UPDATE %s set VALUE = [1, 1 + (int) ?] WHERE pk = 0", 1); + test.run(); + } + + @Test + public void functions() + { + VectorType<Integer> type = VectorType.getInstance(Int32Type.instance, 2); + Vector<Integer> vector = vector(1, 2); + + NativeFunctions.instance.add(new NativeScalarFunction("f", type, type) + { + @Override + public ByteBuffer execute(ProtocolVersion protocol, List<ByteBuffer> parameters) + { + return parameters.get(0); + } + }); + + createTable(KEYSPACE, "CREATE TABLE %s (pk int primary key, value vector<int, 2>)"); + execute("INSERT INTO %s (pk, value) VALUES (0, ?)", vector); + + assertRows(execute("SELECT f(value) FROM %s WHERE pk=0"), row(vector)); + // TODO org.apache.cassandra.cql3.selection.Selectable.WithList isn't vector aware, so the below function will fail +// assertRows(execute("SELECT f([1, 2]) FROM %s WHERE pk=0"), row(vector)); Review Comment: This seems to work at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
