maedhroz commented on code in PR #2409: URL: https://github.com/apache/cassandra/pull/2409#discussion_r1227229654
########## src/java/org/apache/cassandra/index/sai/disk/v1/kdtree/OneDimBKDPostingsWriter.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.cassandra.index.sai.disk.v1.kdtree; + +import java.io.IOException; +import java.util.Collection; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.PriorityQueue; +import java.util.TreeMap; +import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; + +import com.google.common.base.Stopwatch; +import com.google.common.collect.HashMultimap; +import com.google.common.collect.Iterables; +import com.google.common.collect.Multimap; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.agrona.collections.IntArrayList; +import org.apache.cassandra.config.CassandraRelevantProperties; +import org.apache.cassandra.index.sai.IndexContext; +import org.apache.cassandra.index.sai.disk.v1.postings.MergePostingList; +import org.apache.cassandra.index.sai.disk.v1.postings.PackedLongsPostingList; +import org.apache.cassandra.index.sai.disk.v1.postings.PostingsWriter; +import org.apache.cassandra.index.sai.postings.PeekablePostingList; +import org.apache.cassandra.index.sai.postings.PostingList; +import org.apache.cassandra.utils.FBUtilities; +import org.apache.lucene.store.IndexOutput; +import org.apache.lucene.util.packed.PackedLongValues; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkState; + +/** + * Writes auxiliary posting lists for bkd tree nodes. If a node has a posting list attached, it will contain every row + * id + * from all leaves reachable from that node. + * + * Writer is stateful, because it needs to collect data from bkd index data structure first to find set of eligible + * nodes and leaf nodes reachable from them. + * + * This is an optimised writer for 1-dim points, where we know that leaf blocks are written in value order (in this + * order we pass them to the {@link BKDWriter}). That allows us to skip reading the leaves, instead just order leaf + * blocks by their offset in the index file, and correlate them with buffered posting lists. We can't make this + * assumption for multi-dim case. + */ +public class OneDimBKDPostingsWriter implements TraversingBKDReader.IndexTreeTraversalCallback Review Comment: https://github.com/apache/cassandra/pull/2409/files#r1227216477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
