mike-tr-adamson commented on code in PR #2409: URL: https://github.com/apache/cassandra/pull/2409#discussion_r1229412341
########## src/java/org/apache/cassandra/index/sai/disk/v1/bbtree/IntersectingPointValues.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.cassandra.index.sai.disk.v1.bbtree; + +import java.io.IOException; + +import org.apache.lucene.codecs.MutablePointValues; +import org.apache.lucene.index.PointValues; +import org.apache.lucene.util.BytesRef; + +public abstract class IntersectingPointValues extends MutablePointValues +{ + private static final byte[] EMPTY = new byte[0]; + + public boolean needsSorting() + { + return size() > 1; + } + + public abstract void intersect(IntersectVisitor visitor) throws IOException; + + @Override + public int getDocCount() + { + throw new UnsupportedOperationException(); + } + + @Override + public long size() + { + return 1; + } + + @Override + public void getValue(int i, BytesRef packedValue) + { + // no-op + } + + @Override + public byte getByteAt(int i, int k) + { + return 0; Review Comment: I've changed all the methods that are returning dummy values to return `UnsupportedOperationException`. These methods are only used in the sort operation and that is only done if `size() > 0`. This is only the case for the implementation in `BlockBalancedTreeRamBuffer` where the values need sorting. On a related subject. It seems to me that the only reason that we are using `PointValues` at all is because of the sort. This is needed because the values in `BlockBalancedTreeRamBuffer` are not sorted. One option here would be to change how we build the in-memory numerics such that they are naturally sorted. I am thinking of a trie here. This would also give us prefix compression of the values as they are built in-memory, which we don't have with the current implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
