ekaterinadimitrova2 commented on code in PR #2358:
URL: https://github.com/apache/cassandra/pull/2358#discussion_r1231586217
##########
build.xml:
##########
@@ -306,8 +306,15 @@
<equals arg1="${ant.java.version}" arg2="17"/>
</condition>
- <!-- needed to compile org.apache.cassandra.utils.JMXServerUtils -->
- <condition property="jdk11plus-javac-exports" value="--add-exports
java.rmi/sun.rmi.registry=ALL-UNNAMED" else="">
+ <resources id="_jdk11plus_javac_export_args">
+ <!-- needed to compile org.apache.cassandra.utils.JMXServerUtils -->
+ <string>--add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED</string>
+ <!-- needed to compile org.apache.cassandra.utils.memory.BufferPool -->
+ <string>--add-exports java.base/jdk.internal.ref=ALL-UNNAMED</string>
+ <string>--add-exports java.base/sun.nio.ch=ALL-UNNAMED</string>
Review Comment:
Oh, wrong PR/branch :( I will post now on the right one too...Got confused
for a moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
