maedhroz commented on code in PR #2409: URL: https://github.com/apache/cassandra/pull/2409#discussion_r1232584449
########## src/java/org/apache/cassandra/index/sai/disk/v1/segment/NumericIndexSegmentSearcher.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.cassandra.index.sai.disk.v1.segment; + +import java.io.IOException; +import java.lang.invoke.MethodHandles; + +import com.google.common.base.MoreObjects; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.cassandra.index.sai.IndexContext; +import org.apache.cassandra.index.sai.QueryContext; +import org.apache.cassandra.index.sai.disk.PrimaryKeyMap; +import org.apache.cassandra.index.sai.disk.format.IndexComponent; +import org.apache.cassandra.index.sai.disk.v1.PerColumnIndexFiles; +import org.apache.cassandra.index.sai.disk.v1.bbtree.BlockBalancedTreeReader; +import org.apache.cassandra.index.sai.iterators.KeyRangeIterator; +import org.apache.cassandra.index.sai.metrics.MulticastQueryEventListeners; +import org.apache.cassandra.index.sai.metrics.QueryEventListener; +import org.apache.cassandra.index.sai.plan.Expression; +import org.apache.cassandra.index.sai.postings.PostingList; + +import static org.apache.cassandra.index.sai.disk.v1.bbtree.BlockBalancedTreeQueries.balancedTreeQueryFrom; + +/** + * Executes {@link Expression}s against the balanced tree for an individual index segment. + */ +public class NumericIndexSegmentSearcher extends IndexSegmentSearcher +{ + private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + private final BlockBalancedTreeReader treeReader; + private final QueryEventListener.BalancedTreeEventListener perColumnEventListener; + + NumericIndexSegmentSearcher(PrimaryKeyMap.Factory primaryKeyMapFactory, + PerColumnIndexFiles perIndexFiles, + SegmentMetadata segmentMetadata, + IndexContext indexContext) throws IOException + { + super(primaryKeyMapFactory, perIndexFiles, segmentMetadata, indexContext); + + final long treePosition = metadata.getIndexRoot(IndexComponent.BALANCED_TREE); + assert treePosition >= 0; + final long postingsPosition = metadata.getIndexRoot(IndexComponent.POSTING_LISTS); + assert postingsPosition >= 0; Review Comment: Should we just throw `CorruptIndexException` or something similar in these cases. `assert` feels wrong, as this could be a result of something like file tampering? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
