belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1241227430
##########
accord-core/src/main/java/accord/primitives/Routables.java:
##########
@@ -48,21 +48,21 @@ enum Slice
boolean isEmpty();
boolean intersects(AbstractRanges<?> ranges);
- boolean intersects(AbstractKeys<?, ?> keys);
- default boolean intersects(Routables<?, ?> routables)
+ boolean intersects(AbstractKeys<?> keys);
+ default boolean intersects(Routables<?> routables)
{
switch (routables.domain())
{
default: throw new AssertionError();
- case Key: return intersects((AbstractKeys<?, ?>) routables);
+ case Key: return intersects((AbstractKeys<?>) routables);
case Range: return intersects((AbstractRanges<?>) routables);
}
}
boolean contains(RoutableKey key);
- boolean containsAll(Routables<?, ?> keysOrRanges);
+ boolean containsAll(Routables<?> keysOrRanges);
- U slice(Ranges ranges);
- Routables<K, ?> slice(Ranges ranges, Slice slice);
+ Routables slice(Ranges ranges);
Review Comment:
:+1: I think this is due to a bug in IntelliJ's refactoring of generic types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
