maedhroz commented on code in PR #2420:
URL: https://github.com/apache/cassandra/pull/2420#discussion_r1245689683
##########
src/java/org/apache/cassandra/io/sstable/SSTableZeroCopyWriter.java:
##########
@@ -195,14 +197,16 @@ public void close()
writer.close();
}
- public void writeComponent(Component.Type type, DataInputPlus in, long
size) throws ClosedChannelException
+ public void writeComponent(Component component, DataInputPlus in, long
size) throws ClosedChannelException
{
- logger.info("Writing component {} to {} length {}", type,
componentWriters.get(type).getPath(), prettyPrintMemory(size));
+ @SuppressWarnings({"resource", "RedundantSuppression"}) // all
writers are closed in close()
Review Comment:
Curious...can individual writers fail and cause some writers not to be
closed? (above, on 197)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
