michaelsembwever commented on code in PR #2434:
URL: https://github.com/apache/cassandra/pull/2434#discussion_r1246536257
##########
.circleci/config.yml:
##########
@@ -4131,7 +4131,7 @@ jobs:
git clean -fd
# Loop to prevent failure due to maven-ant-tasks not downloading a
jar..
for x in $(seq 1 3); do
- ${ANT_HOME}/bin/ant realclean; ${ANT_HOME}/bin/ant jar
dtest-jar
+ ${ANT_HOME}/bin/ant realclean; ${ANT_HOME}/bin/ant jar
dtest-jar -Dno-checkstyle=true -Dno-check=true
Review Comment:
it shouldn't be necessary to supply both `-Dno-checkstyle=true
-Dno-check=true`
i.e. `-Dno-check=true` should imply `-Dno-checkstyle=true -Drat.skip=true
-Declipse-warnings.skip=true -Ddependency-check.skip=true`
here's a patch i was playing with before…
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/buildfiles-linter-docs/4.1
( that patch also allows you to specify there shorter form of `-Dno-linter=`
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
