maedhroz commented on code in PR #2409:
URL: https://github.com/apache/cassandra/pull/2409#discussion_r1247207487
##########
src/java/org/apache/cassandra/index/sai/disk/v1/postings/PostingsWriter.java:
##########
@@ -123,7 +128,6 @@ public PostingsWriter(IndexDescriptor indexDescriptor,
IndexContext indexContext
private PostingsWriter(IndexOutput dataOutput, int blockSize) throws
IOException
{
assert dataOutput instanceof IndexOutputWriter;
Review Comment:
Any reason not to remove this `assert` and just change the type of
`dataOutput` to `IndexOutputWriter`? I tried it, and after a couple minor
changes up through to `NumericIndexWriter` (where `openPerIndexOutput()` does
give us an `IndexOutputWriter ) it seems to work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
