adelapena commented on code in PR #2465:
URL: https://github.com/apache/cassandra/pull/2465#discussion_r1252966345
##########
src/java/org/apache/cassandra/index/sai/analyzer/AbstractAnalyzer.java:
##########
@@ -22,12 +22,22 @@
import java.util.Iterator;
import java.util.Map;
import java.util.NoSuchElementException;
+import java.util.Set;
+
+import com.google.common.collect.ImmutableSet;
import org.apache.cassandra.db.marshal.AbstractType;
+import org.apache.cassandra.db.marshal.AsciiType;
+import org.apache.cassandra.db.marshal.UTF8Type;
+import org.apache.cassandra.exceptions.InvalidRequestException;
+import org.apache.cassandra.index.sai.utils.TypeUtil;
public abstract class AbstractAnalyzer implements Iterator<ByteBuffer>
{
+ public static final Set<AbstractType<?>> ANALYZABLE_TYPES =
ImmutableSet.of(UTF8Type.instance, AsciiType.instance);
Review Comment:
Maybe it's simpler to get rid of `ANALYZABLE_TYPES` and `TypeUtil#isIn` and
just use `(type instanceof StringType)` to check if a type is analyzable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
