maedhroz commented on PR #2460:
URL: https://github.com/apache/cassandra/pull/2460#issuecomment-1622413371
> It seems CI is hitting some new test failures around NodeRestartTest and
SnapshotTest, I haven't looked into them yet.
@pkolaczk @adelapena I think the failures are due to us calling
`validatePerIndexComponents()` and `validatePerSSTableComponents()` in
`IndexDescriptor` w/ `IndexValidation.NONE` rather than not at all. The counter
injections in `SAITester` depend on this. You could fix by changing them to...
```
protected static final Injections.Counter perSSTableValidationCounter =
Injections.newCounter("PerSSTableValidationCounter")
.add(newInvokePoint().onClass(OnDiskFormat.class)
.onMethod("validatePerSSTableIndexComponents"))
.build();
protected static final Injections.Counter perColumnValidationCounter =
Injections.newCounter("PerColumnValidationCounter")
.add(newInvokePoint().onClass(OnDiskFormat.class)
.onMethod("validatePerColumnIndexComponents"))
.build();
```
After that, `shouldTakeAndRestoreSnapshots()` in `SnapshotTest` will still
fail, and that's because the test was always incorrect. Changing line 107 to
`assertValidationCount(4, 2);` should properly verify that full rebuild
checksums the SSTable-level index components.
Alright, on to the rest of the review. Hopefully that helps :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
