Maxwell-Guo commented on code in PR #2469:
URL: https://github.com/apache/cassandra/pull/2469#discussion_r1254376689
##########
test/unit/org/apache/cassandra/cql3/validation/operations/CQLVectorTest.java:
##########
@@ -139,6 +140,95 @@ public void insertNonPK()
test.run();
}
+ @Test
+ public void cannotInsertWrongNumberOfDimensionsFixedWidth() throws
Throwable
Review Comment:
what about change the function name to : wrongNumberOfDimensionsFixedWidth,
and the following function names are also the same to remove "cannotInsert",
although the function name explains what to do in detail, but I feel a bit
long;
In my mind these tests are all validations for throw exception
messages(assertInvalidThrowMessage function everywhere), that is to say the
code in the function is saying that wrongNumberxxx will throw an exception.
And wrongNumber and wrongElement is saying this is abnormal error test
test(the name is wrongXXX).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
