smiklosovic commented on code in PR #2458:
URL: https://github.com/apache/cassandra/pull/2458#discussion_r1257905441
##########
src/java/org/apache/cassandra/locator/Ec2MetadataServiceConnector.java:
##########
@@ -45,7 +45,7 @@ abstract class Ec2MetadataServiceConnector extends
AbstractCloudMetadataServiceC
Ec2MetadataServiceConnector(SnitchProperties properties)
{
- super(properties.get(EC2_METADATA_URL_PROPERTY,
DEFAULT_EC2_METADATA_URL));
+ super(properties.get(EC2_METADATA_URL_PROPERTY,
properties.get(METADATA_URL_PROPERTY, DEFAULT_EC2_METADATA_URL)));
Review Comment:
Good question.
`METADATA_URL_PROPERTY = "metadata_url"`
and
`EC2_METADATA_URL_PROPERTY = "ec2_metadata_url"`.
The latter was introduced when we were doing IDMSv2 for AWS but with this PR
in place, I wanted to be backward compatible.
As `ec2_metadata_url` key is in 3.0 -> 4.1 but it would not be in trunk,
then upgrading to trunk would fail because that key would not be there anymore.
On the other hand, if one deploys it to trunk for the first time, it can set
the url like "metadata_url" and I like the idea that metadata_url property
would be same for all cloud snitches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
