maedhroz commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1264244156


##########
src/java/org/apache/cassandra/index/SecondaryIndexManager.java:
##########
@@ -490,10 +490,58 @@ public static String getIndexName(String cfName)
         assert isIndexColumnFamily(cfName);
         return StringUtils.substringAfter(cfName, 
Directories.SECONDARY_INDEX_NAME_SEPARATOR);
     }
+    
+    public void buildIndexesBlockingIncremental(Collection<SSTableReader> 
sstables)

Review Comment:
   I'll JavaDoc this when we're closer having the patch approved, but basically 
it's a version of `buildIndexesBlocking()` that doesn't touch the index 
queryability/status. It is here to build indexes for new SSTables before they 
are actually added to the tracker, and so failures have no bearing on those 
things...except, of course, for failing the upstream operation and making sure 
the SSTables themselves never become readable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to