smiklosovic commented on code in PR #2490:
URL: https://github.com/apache/cassandra/pull/2490#discussion_r1264732233
##########
src/java/org/apache/cassandra/service/CassandraDaemon.java:
##########
@@ -259,6 +259,8 @@ protected void setup()
CommitLog.instance.start();
+ installCryptoProvider();
Review Comment:
Why not to do this installation logic in `CassandraDaemon.activate()`
method? There is `applyConfig()` at the very beginning. Then it will eventually
propagate to `DatabaseDescriptor.applyAll()`.
You can do the startup check first and then do the installation after that,
at the very end, still part of `applyAll`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
