jbellis commented on code in PR #2495:
URL: https://github.com/apache/cassandra/pull/2495#discussion_r1265395743
##########
src/java/org/apache/cassandra/index/sai/iterators/KeyRangeIterator.java:
##########
@@ -106,13 +107,21 @@ else if (next.compareTo(nextKey) >= 0)
return recomputeNext();
}
+ /**
+ * Skip to nextKey.
+ *
+ * That is, implementations should set up the iterator state such that
+ * calling computeNext() will return nextKey if present,
+ * or the first one after it if not present.
+ */
protected abstract void performSkipTo(PrimaryKey nextKey);
- protected PrimaryKey recomputeNext()
+ private PrimaryKey recomputeNext()
{
return tryToComputeNext() ? peek() : endOfData();
}
+ // protected because inherited from Guava. We don't want to expose this
method.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
