Claudenw commented on code in PR #2282:
URL: https://github.com/apache/cassandra/pull/2282#discussion_r1268251609
##########
src/java/org/apache/cassandra/schema/CompressionParams.java:
##########
@@ -230,21 +230,27 @@ private static CompressionParams
fromClassAndOptions(String sstableCompressionCl
max_compressed_length_in_bytes =
CompressionParams.calcMaxCompressedLength(chunk_length_in_bytes,
min_compress_ratio);
}
- // try to set compressor type
- CompressorType compressorType =
StringUtils.isEmpty(sstableCompressionClass) ? DEFAULT_COMPRESSION_TYPE : null;
- if (compressorType == null)
+ CompressorType compressorType = null;
+ try
{
- try
+ compressorType = CompressorType.valueOf(sstableCompressionClass);
+ }
+ catch (Exception e)
+ {
+ // intentionally empty
+ }
+
+ Function<Map<String,String>, ICompressor> creator = compressorType !=
null ? compressorType.creator : (opt) -> {
+ if (sstableCompressionClass != null)
{
- compressorType =
CompressorType.valueOf(sstableCompressionClass);
+ return
FBUtilities.newCompressor(parseCompressorClass(sstableCompressionClass), opt);
}
- catch (IllegalArgumentException expected)
+ else
{
- compressorType =
CompressorType.forClass(sstableCompressionClass);
+ return
FBUtilities.newCompressor(parseCompressorClass(defaultParams().klass().getName()),
opt);
}
- }
+ };
Review Comment:
THis block can be replaced with:
```
Function<Map<String,String>, ICompressor> creator = null;
// try to set compressor type
CompressorType compressorType = null;
if (!StringUtils.isEmpty(sstableCompressionClass))
{
try
{
compressorType =
CompressorType.valueOf(sstableCompressionClass);
}
catch (IllegalArgumentException expected)
{
compressorType =
CompressorType.forClass(sstableCompressionClass);
}
creator = compressorType != null ? compressorType.creator :
(opt) ->
FBUtilities.newCompressor(parseCompressorClass(sstableCompressionClass), opt);
} else {
creator = (opt) ->
FBUtilities.newCompressor(parseCompressorClass(defaultParams().klass().getName()),
opt);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
