adelapena commented on code in PR #2498:
URL: https://github.com/apache/cassandra/pull/2498#discussion_r1269299791
##########
src/java/org/apache/cassandra/index/sai/disk/format/OnDiskFormat.java:
##########
@@ -136,7 +136,7 @@ PerColumnIndexWriter
newPerColumnIndexWriter(StorageAttachedIndex index,
* This is a complete set of components that could exist on-disk. It does
not imply that the
* components currently exist on-disk.
*/
- Set<IndexComponent> perSSTableIndexComponents();
+ Set<IndexComponent> perSSTableIndexComponents(boolean hasClustering);
Review Comment:
Nit: add `@param` JavaDoc for `hasClustering`
##########
src/java/org/apache/cassandra/index/sai/disk/format/OnDiskFormat.java:
##########
@@ -152,7 +152,7 @@ PerColumnIndexWriter
newPerColumnIndexWriter(StorageAttachedIndex index,
* This is a static indication of the files that can be held open by an
index
* for queries. It is not a dynamic calculation.
*/
- int openFilesPerSSTableIndex();
+ int openFilesPerSSTableIndex(boolean hasClustering);
Review Comment:
Nit: add `@param` JavaDoc for `hasClustering`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
