smiklosovic commented on code in PR #2490:
URL: https://github.com/apache/cassandra/pull/2490#discussion_r1269844540
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1217,6 +1222,27 @@ public static void applySslContext()
}
}
+ public static void applyCryptoProvider()
+ {
+ try
+ {
+ if (conf.crypto_provider == null)
+ conf.crypto_provider = new
ParameterizedClass(NoOpCryptoProvider.class.getName(), null);
+
+ if (conf.crypto_provider.class_name == null)
Review Comment:
@ayushisingh29 if you throw an exception because `class_name` is null, it
will be caught in the catch block but there you are referencing
`conf.crypto_provider.class_name` and you call `toString()` on it. So while you
caught the exception, it may throw `NullPointerException` in that catch block
again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
