ekaterinadimitrova2 commented on code in PR #2503:
URL: https://github.com/apache/cassandra/pull/2503#discussion_r1270741787
##########
build.xml:
##########
@@ -1881,10 +1849,10 @@
</java>
</target>
- <target name="_maybe_update_idea_to_java11plus" depends="init"
unless="java.version.8">
- <replace file="${eclipse.project.name}.iml" token="JDK_1_8"
value="JDK_${ant.java.version}"/>
- <replace file=".idea/misc.xml" token="JDK_1_8"
value="JDK_${ant.java.version}"/>
- <replace file=".idea/misc.xml" token="1.8" value="${ant.java.version}"/>
+ <target name="_maybe_update_idea_to_java11plus" depends="init">
Review Comment:
` maybe we can update idea files directly?`
What do you mean by directly? We need that token change for when we want to
build&run things on 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
