jacek-lewandowski commented on code in PR #2464:
URL: https://github.com/apache/cassandra/pull/2464#discussion_r1271938929
##########
src/java/org/apache/cassandra/db/DeletionTime.java:
##########
@@ -195,42 +195,95 @@ public static Serializer getSerializer(Version version)
return legacySerializer;
}
- // Serializer for Usigned Integer ldt
+ /* Serializer for Usigned Integer ldt
+ *
+ * ldt is encoded as a uint in seconds since unix epoch, it can go up o
2106-02-07T06:28:13+00:00 only.
+ * mfda is a positive timestamp. We use the sign bit to enconde LIVE
DeletionTimes
+ */
public static class Serializer implements ISerializer<DeletionTime>
{
+ // We use the sign bit to signal LIVE DeletionTimes
+ private final static int IS_LIVE_DELETION = 0b1000_0000;
Review Comment:
I was under the impression that the `1` in `0b1000_0000` should be a flags
byte presence marker - so it denotes that the remaining 7 bits should be
interpreted as flags. Then, LIVE is one of those flags. Perhaps it does not
makes much sense because it is hardly to imagine what could be stored there
🤷🏻♂️ Anyway, I've already approved so you do not have to bother
##########
src/java/org/apache/cassandra/db/DeletionTime.java:
##########
@@ -195,42 +195,95 @@ public static Serializer getSerializer(Version version)
return legacySerializer;
}
- // Serializer for Usigned Integer ldt
+ /* Serializer for Usigned Integer ldt
+ *
+ * ldt is encoded as a uint in seconds since unix epoch, it can go up o
2106-02-07T06:28:13+00:00 only.
+ * mfda is a positive timestamp. We use the sign bit to enconde LIVE
DeletionTimes
+ */
public static class Serializer implements ISerializer<DeletionTime>
{
+ // We use the sign bit to signal LIVE DeletionTimes
+ private final static int IS_LIVE_DELETION = 0b1000_0000;
Review Comment:
I was under the impression that the `1` in `0b1000_0000` should be a flags
byte presence marker - so it denotes that the remaining 7 bits should be
interpreted as flags. Then, LIVE is one of those flags. Perhaps it does not
makes much sense because it is hardly to imagine what could be stored there
🤷🏻♂️ Anyway, I've already approved so you do not have to bother
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
