michaelsembwever commented on code in PR #2282:
URL: https://github.com/apache/cassandra/pull/2282#discussion_r1273219112
##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -360,8 +360,14 @@ public Builder()
{
}
- public TableParams build()
+ public TableParams build(String keyspace, String name)
{
+ if (compression == null)
+ if
(SchemaConstants.getLocalAndReplicatedSystemKeyspaceNames().contains(keyspace))
+ compression = CompressionParams.DEFAULT;
+ else
+ compression = CompressionParams.defaultParams();
+
Review Comment:
i'm uneasy about this change, hardcoding it to `.getLocalAndReplcateSystem
KeyspaceNames()`, and introducing keyspace and table_name (the latter which is
not even used anywhere) into the `.build()` method (which impacts a lot of
calling code).
I would like more reviewers on this particular aspect, e.g. @blerer
(and because of this I think we don't try to squeeze/rush this into 5.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
