smiklosovic commented on code in PR #2282:
URL: https://github.com/apache/cassandra/pull/2282#discussion_r1273340482
##########
src/java/org/apache/cassandra/schema/TableParams.java:
##########
@@ -360,8 +360,14 @@ public Builder()
{
}
- public TableParams build()
+ public TableParams build(String keyspace, String name)
{
+ if (compression == null)
+ if
(SchemaConstants.getLocalAndReplicatedSystemKeyspaceNames().contains(keyspace))
+ compression = CompressionParams.DEFAULT;
+ else
+ compression = CompressionParams.defaultParams();
+
Review Comment:
@michaelsembwever I am all ears how you would do that differently. This
seems to be the least invasive change. I am aware of the fact that table
parameter is not used _yet_. What if we want to have more granular resolution
of this logic in the future? So table param would be already there ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
